Report a bug #430

Queue gets stuck, when hostname is longer than 30 chars

Added by Georg almost 5 years ago. Updated over 4 years ago.

Status:ClosedStart date:2015-08-03
Priority:NormalDue date:
Assignee:Daniel% Done:

100%

Category:-Estimated time:1.00 hour
Target version:HRM Development - 3.3.0

Description

If the hostname of the HRM worker is longer than 30 chars the queue gets stuck.
This is due to the QueueManager kicking of the job and reserving the worker and then trying to set the job to running. If that fails no error gets thrown and the worker stays in the reserved state.

I attached a patch that reports the error and sets the state of the worker to free again if updating the database fails.

Best regards,
Georg

hostname_longer_than_30.patch Magnifier (1.29 KB) Georg, 2015-08-03 17:55

History

#1 Updated by Georg almost 5 years ago

I just noticed that there is a Github repository.
Would you like me to open a PR on Github, or is this the preferred way to submit patches to HRM?

Best regards,
Georg

#2 Updated by Niko almost 5 years ago

Hi Georg,

sure, using github for submitting PR's is perfect!

https://github.com/aarpon/hrm

Cheers
Niko

#3 Updated by Daniel almost 5 years ago

  • Target version set to 3.3.0

Also change the 'server' field of table 'job_queue' from 30 to 255 characters.

This will be taken care of by the database update script in HRM 3.3.

#4 Updated by Aaron over 4 years ago

  • Assignee set to Daniel

Check which branch this was committed to and merge into hotfix/3.2.2.

#5 Updated by Daniel over 4 years ago

  • % Done changed from 0 to 80

#6 Updated by Daniel over 4 years ago

  • Status changed from New to Resolved - Test / Merge
  • % Done changed from 80 to 100

It seems that it was never committed.

Fixed now in 'devel' branch, commit 269b047.

#7 Updated by Aaron over 4 years ago

  • Status changed from Resolved - Test / Merge to Closed

Also available in: Atom PDF