Report a bug #360

Jobs fail when subimages of LIF file contain two consecutive blanks

Added by Sebastian about 5 years ago. Updated about 3 years ago.

Status:Wait For FeedbackStart date:2015-02-17
Priority:NormalDue date:
Assignee:Daniel% Done:

0%

Category:Bug
Target version:HRM Development - 4.0.0

Description

Dear HRM developers,

Deconvolution jobs fail when I supply a LIF file with subimages that have two consecutive blanks in the name. The error message is as follows:

Error: failed task 0: ReportErrorAndExit: fatal error: Failed to open /local/data/huygens_data/uhrigs/src/subimages_with_two_blanks.lif for original, got Error: command img_open: Failed to open file.Error: Failed to open file.

I tracked the issue down to select_images.php. I believe it collapses two consecutive spaces to one: In the list "Selected Images" it already shows only one blank. If I modify the job script (.hgsp file in the upload folder) to correctly reflect the two blanks, then the job runs fine.

If you want me to supply a sample file, just ask. But the error is fairly easy to reproduce.

Regards,
Sebastian

History

#1 Updated by Niko about 5 years ago

  • Status changed from New to Wait For Feedback
  • Assignee set to Daniel

Hi Sebastian,

this sounds exactly like bug #230 that was supposed to be fixed in 3.2.0 - could you confirm which version of the HRM you are running?

As far as I can see Daniel made the fixes back then, maybe you could have a look at the history of this file together?

https://github.com/aarpon/hrm/commits/master/select_images.php

Cheers
~Niko

#2 Updated by Sebastian about 5 years ago

Hi Niko,

We are using version 3.2.1. But I recently had a similar issue with blanks in file names on the file selector page (see bug #342). Daniel gave me a patch for this. Maybe this introduced a regression?

I cannot find a bug with #230, but if you are referring to this change: https://github.com/aarpon/hrm/commit/7de1fd0301becbf2ef6b2816b3962bd4d4d2bd10
then, I agree my bug report does sound very much the same.

Regards,
Sebastian

#3 Updated by Aaron almost 5 years ago

  • Category set to Bug
  • Target version set to 3.3.0

#4 Updated by Aaron over 4 years ago

Daniel will look up the patch he sent to Sebastian and attach it to the issue. The blank space code '160' was reverted in a later commit to standard  . This might have fixed the issue already.

#5 Updated by Aaron over 4 years ago

  • Target version changed from 3.3.0 to 3.4.0

#6 Updated by Daniel about 3 years ago

I've looked all over the place but could not find the patch that I sent to Sebastian.

#7 Updated by Aaron about 3 years ago

  • Target version changed from 3.4.0 to 4.0.0

We should have some core functionality in FileserverV2 that takes care of robust string escaping and handling, to be used in HTML + Javascript, to be passed on to QM/hucore and if still needed to be stored in the DB. Most likely, there are libraries on packagist.org for this purpose.

Also available in: Atom PDF